Fix on delete cascade entity order #20949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since [netbox-community#20708](netbox-community#20708) relation with a on delete RESTRICT are not deleted in the proper order. Then the error `violate not-null constraint` occurs and breaks the delete cascade feature.
jeremystretch
requested review from
a team and
jeremystretch
and removed request for
a team and
jeremystretch
Member
|
Per our contributing guide, please don't submit a PR for an issue until it has been accepted and assigned to you for work. |
jnovinger
requested review from
a team and
jeremystretch
and removed request for
a team
jeremystretch
requested changes
Dec 22, 2025
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
@fanshan please avoid including unrelated and unnecessary changes when submitting a PR. The only relevant change here is on line 224.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since #20708 relation with a on delete RESTRICT are not deleted in the proper order. Then the error
violate not-null constraintoccurs and breaks the delete cascade feature.Fixes: #20948
This PR try to fix object on delete order when a relation was set with the action
RESTRICTon delete event.